feat: flexible timing #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x4007
reviewed
Jun 14, 2024
Co-authored-by: アレクサンダー.eth <[email protected]>
Co-authored-by: アレクサンダー.eth <[email protected]>
0x4007
approved these changes
Jun 19, 2024
whilefoo
suggested changes
Jun 19, 2024
|
Consider renaming the property names: warning: "3.5 days" I always prefer one word property names when possible. There is less cognitive overhead dealing with these. |
whilefoo
approved these changes
Jun 21, 2024
gentlementlegen
merged commit b56072d
into
ubiquity-os-marketplace:development
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2
Depends on #1
QA run: Meniole/todel#6