This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Online Plugin Manager #2
Open
sean-e-dietrich
wants to merge
14
commits into
uberhacker:master
Choose a base branch
from
sean-e-dietrich:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @sean-e-dietrich: Thank you for the effort to improve the search functionality. I like how you organized the search results in table format. I also really like the idea of an 'official' Terminus plugin registry. There are a few problems with this approach, however:
I'm going to strip out the search functionality from here into a separate companion plugin so Pantheon can eventually drop PluginCommand.php into Terminus core. You are welcome to add another search plugin that "competes" with mine but I imagine both of our methods will need a complete rewrite once Pantheon standardizes on using Composer to install plugins. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created modification that plugins could be added over on http://live-terminus-plugins.pantheonsite.io and from there they would be searchable.
Using the following example. Partial plugin name is searched so whether you type term or terminus they will search to see if the package name contains the word. Similar to the linux package manager apt-get.
This would be output
Once I know the package name I can use the install option to install the remote package.
I can also use the remote git repository if the repo instead using the following
Most of the other functionality works as previously intended. I also knixed saving everything to a repo file.