Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relay does not remove items when the remote connection fails #390

Open
prashantv opened this issue Jun 2, 2016 · 0 comments
Open

Relay does not remove items when the remote connection fails #390

prashantv opened this issue Jun 2, 2016 · 0 comments
Labels
bug relay

Comments

@prashantv
Copy link
Contributor

If a relay is set up from C1 to C2, and C2 fails, C1 does not get an error frame. Instead, the relay item will timeout and the caller will receive a "timeout".

Message exchanges are stopped on connection errors:
https://github.com/uber/tchannel-go/blob/dev/connection.go#L684

Relay items should have the same behaviour.
akshayjshah pushed a commit that referenced this issue Jun 11, 2016
Disable relaying in flaky test
633dc3b 
As mentioned in the pre-existing comment, enabling relaying makes this
test flaky. We can re-enable once #390 is resolved.
akshayjshah pushed a commit that referenced this issue Jun 11, 2016
Disable relaying in flaky test
e02e342 
As mentioned in the pre-existing comment, enabling relaying makes this
test flaky. We can re-enable once #390 is resolved.
@akshayjshah akshayjshah mentioned this issue Jun 11, 2016
Closed
akshayjshah pushed a commit that referenced this issue Jun 11, 2016
Disable relaying in flaky test
818b1b3 
As mentioned in the pre-existing comment, enabling relaying makes this
test flaky. We can re-enable once #390 is resolved.
akshayjshah pushed a commit that referenced this issue Jun 11, 2016
Disable relaying in flaky test
a3a2be9 
As mentioned in the pre-existing comment, enabling relaying makes this
test flaky. We can re-enable once #390 is resolved.
akshayjshah pushed a commit that referenced this issue Jun 11, 2016
Disable relaying in flaky test
8c38015 
As mentioned in the pre-existing comment, enabling relaying makes this
test flaky. We can re-enable once #390 is resolved.
@prashantv prashantv mentioned this issue Dec 9, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug relay
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@prashantv