Skip to content

Commit

Permalink
Disable relaying in flaky test
Browse files Browse the repository at this point in the history
As mentioned in the pre-existing comment, enabling relaying makes this
test flaky. We can re-enable once #390 is resolved.
  • Loading branch information
Akshay Shah committed Jun 11, 2016
1 parent eca8a4c commit a3a2be9
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions connection_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,13 @@ import (
"time"

. "github.com/uber/tchannel-go"

"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"github.com/uber/tchannel-go/raw"
"github.com/uber/tchannel-go/relay"
"github.com/uber/tchannel-go/testutils"
"github.com/uber/tchannel-go/testutils/testreader"

"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"golang.org/x/net/context"
)

Expand Down Expand Up @@ -548,7 +549,7 @@ func TestWriteAfterConnectionError(t *testing.T) {
// Closing network connections can lead to warnings in many places.
// TODO: Relay is disabled due to https://github.com/uber/tchannel-go/issues/390
// Enabling relay causes the test to be flaky.
opts := testutils.NewOpts().DisableLogVerification()
opts := testutils.NewOpts().DisableLogVerification().NoRelay()
testutils.WithTestServer(t, opts, func(ts *testutils.TestServer) {
testutils.RegisterEcho(ts.Server(), nil)
server := ts.Server()
Expand Down

0 comments on commit a3a2be9

Please sign in to comment.