Add support for Swift Concurrency

[garricn]

• Modify Generator, NeedleFoundation, and all Samples to support Swift Concurrency
• Set SWIFT_STRICT_CONCURRENCY to Complete to all Samples
• Remove actor isolated code from non-isolated deinits in Samples
• Run make install to install new needle executable in bin

Hoping to merge #471 and #473 first.

[tinder-cfuller]

Hello @rudro! 👋 May you please take time to review and approve this PR? Having these concurrency changes in is crucial for strict concurrency checking and Swift 6 adoption. Thank you!!

[tinder-cfuller]

@rudro Now that Swift 5.10 is released, this is becoming more and more critical. What can we do to get this reviewed and merged in? Please advise. Thank you!

[tinder-cfuller]

@rudro May you please advise next steps on this PR? May it be merged in? Thank you! 🙏

[tinder-cfuller]

@rudro If you may please reply indicating whether this PR will be accepted, or not, this information will be very helpful for planning Swift Concurrency adoption as it relates to Needle. Please advise. Thank you!

[alanzeino]

@tinder-cfuller as a temporary step you can point your Podfile or SPM to your forked repo to unblock yourself

I'll chat with Rudro about reviewing this PR, it will need to be carefully looked at and tested — we're not planning on using complete (aka 'strict') concurrency checking internally with needle generated code at this moment.

[tinder-cfuller]

@tinder-cfuller as a temporary step you can point your Podfile or SPM to your forked repo to unblock yourself

I'll chat with Rudro about reviewing this PR, it will need to be carefully looked at and tested — we're not planning on using complete (aka 'strict') concurrency checking internally with needle generated code at this moment.

Hi @alanzeino 👋

Thank you so much for taking a look into this. Very much appreciated. Adding this support to the Uber repo benefits other projects within the community that should not really be depending on my fork.

The @preconcurrency attributes were added intentionally for compatibility with codebases not using complete (aka 'strict') concurrency checking 👍

Please also take note of the two additional PRs in the PR description above as they are related.

Thank you!

[Foixa]

Hello, any news?

[Mistakx]

I would also like to know the state of this PR, since without it projects using Needle can't migrate to Swift 6 and use the new concurrency checks.

[alanzeino]

I would also like to know the state of this PR, since without it projects using Needle can't migrate to Swift 6 and use the new concurrency checks.

Are you sure? You can mark any module as compiling with swift-version = 5 even when using the Swift 6 compiler. Is there a warning or error you can post as an example?

[tinder-cfuller]

Are you sure? You can mark any module as compiling with swift-version = 5 even when using the Swift 6 compiler. Is there a warning or error you can post as an example?

These changes are necessary for adopting the Swift 6 language model and strict concurrency checking (running in Swift 5 compatibility mode or without strict checks is not satisfactory).

[Mistakx]

I'm apprehensive that Apple may suddenly start soft enforcing the usage of Swift 6 by locking new APIs behind it, and believe migrating to Swift 6 as soon as possible is recommended.

Like @tinder-cfuller said, these changes are necessary to support Swift 6, and the project won't compile without them. Marking modules to use Swift 5 is not a long term sustainable option since Apple is moving in this new Concurrency API's direction.