Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds onCancelPan optional prop and adds more calls to cancelPan #887

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alex-bain
Copy link

Hello - thank you for building NebulaGL, it is a fantastic library.

This PR contains two small changes:

  1. Introduces an optional onCancelPan prop to editable-layer, allowing developers to execute their own logic when NebulaGL determines a map panning operation should be interrupted
  2. Adds event.cancelPan() invocations for additional EditModes to ensure event.cancelPan is always being called at the appropriate time

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ibgreen
Copy link
Collaborator

ibgreen commented Oct 10, 2023

Thanks for opening this. In particular, appreciate that docs were added. Testing interactive functions is tricky, but it possible to add a test case or two?

@ibgreen
Copy link
Collaborator

ibgreen commented Oct 30, 2023

@igorDykhta If possible let's see if we can help @alex-bain land this

@chennney

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants