Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct onEdit typing #873

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Correct onEdit typing #873

wants to merge 2 commits into from
+3 −3

Conversation

timnyborg
Copy link
Contributor

Brings it into line with how it's actually used:

nebula.gl/modules/edit-modes/src/types.ts

Line 129 in a3f81bb

onEdit: (editAction: EditAction<TData>) => void;

nebula.gl/modules/layers/src/layers/editable-geojson-layer.ts

Line 413 in 2a96239

onEdit: (editAction: EditAction<FeatureCollection>) => {

@igorDykhta
Copy link
Collaborator

@timnyborg try to update editable-h3-cluster-layer as well

@timnyborg
Copy link
Contributor Author

@timnyborg try to update editable-h3-cluster-layer as well

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorDykhta igorDykhta igorDykhta approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timnyborg @igorDykhta