test: bump version to 1.1.0-beta #870
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Komzpa
approved these changes
Feb 7, 2023
|
@ibgreen, It's interesting, I have all the tests run without errors. Could you tell me in which environment the test is run? It would be great if you could forward the output of the following commands: |
|
Still can't release, some mystic error "lerna ERR! E404 Not Found" |
* fix type exports, imports * fix deps linking, reduce lint warnings * unlock layers peerdeps, object type fix --------- Co-authored-by: VK <[email protected]>
|
Pulled latest, still failing on the WKT tests. Commented out the tests and got a clean publish |
|
I will able to reproduce this crash with your versions of node and yarn. There are two ways to fix this
I think the first option is better Details:Test that falls: describe('Invalid WKT', () => {
let importData: any;
beforeEach(async () => {
importData = await parseImport('POLYGON(zzz)');
});
test('reports error', () => {
expect(importData.valid).toEqual(false);
expect(importData.validationErrors).toEqual(['Invalid WKT']);
});
});Test report: Error trace: Code that call /** Check HTTP Response */
function validHTTPResponse(data: any): boolean {
// HANDLE HTTP status
if (data instanceof Response) {
// 204 - NO CONTENT. This handles cases where e.g. a tile server responds with 204 for a missing tile
if (data.status === 204) {
return false;
}
}
return true;
} |
|
@ibgreen please check, now it should pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Akiyamka Tried to publish this as a beta but get test failures on master: