NOMERGE Add/Replace ts-ignore with ts-expect-error #647
Conversation
athomann
changed the title
examples/advanced/package.json
Outdated
| "@deck.gl/layers": "^8.4.6", | ||
| "@deck.gl/mesh-layers": "^8.4.6", | ||
| "@deck.gl/react": "^8.4.6", | ||
| "@deck.gl/core": "^8.6.0", |
There was a problem hiding this comment.
Great that you are bumping these, but ideally this should be done in a separate PR.
There was a problem hiding this comment.
Will separate out.
| @@ -123,7 +123,7 @@ export function getEditHandleStyle({ feature, shape, index, state }) { | |||
|
|
|||
| switch (shape) { | |||
| case 'circle': | |||
| //@ts-ignore | |||
| // @ts-ignore | |||
There was a problem hiding this comment.
why not expect-error here?
examples/sf/example.js
Outdated
| @@ -38,10 +38,10 @@ const styles = { | |||
| export default class Example extends React.Component< | |||
| {}, | |||
| { | |||
| viewport: Object, | |||
| viewport: Record<string, any>; | |||
There was a problem hiding this comment.
Not your doing, but it seems strange to me that we have typescript syntax in .js files... Should these be renamed to .ts?
| @@ -107,13 +113,16 @@ describe('dragToDraw=false', () => { | |||
| }, | |||
| }; | |||
|
|
|||
| // @ts-expect-error ts-migrate(2304) FIXME: Cannot find name 'expect'. | |||
There was a problem hiding this comment.
This is a lot of expect-errors in the tests.... I don't think we should merge this.
Don't we just need to install some @types package for jest? Or worst case "hand write" a small .d.ts file?
There was a problem hiding this comment.
Yes, a lot of this was automated. Adding @types/jest which will remove the need for these.
|
@igorDykhta Can you rebase and land this? |
yes |
No description provided.