Update Gradle Plugin to 7.4.2 + Fix Overflowing Poetry #257
Conversation
This commit is to keep the build somewhat in line with RIBs and other uber open source projects
Thie commit prefers the slightly newer style of gradle plugin specification
This avoids the infinite poetry in uber#255
| val resolvedParameterTypes = method.parameterTypes | ||
| while (i < size) { | ||
| val parameter = builder.parameters[i] | ||
| val type = javaToKotlinType(resolvedParameterTypes[i]) |
There was a problem hiding this comment.
This is the real type we want, but we can only get it from method (which has the enclosing generic context), but not methodElement (which has the unresolved T as type). Hence, we pass method.parameterTypes into the overriding function.
| funBuilder.addParameter( | ||
| ParameterSpec.builder(it.name, it.type.typeName.toKTypeName()).build()) |
There was a problem hiding this comment.
This toKTypeName eventually creates an infinite loop somewhere in kotlin poet due to the unresolved type references itself in the generic type parameter.
| interface Child { | ||
|
|
||
| @motif.Objects | ||
| abstract class Objects : ObjectComponent<Bar> |
There was a problem hiding this comment.
This is the key ingredient of the repro case, that an Objects inherits a function that contains a self-referencing generic parameter
| @@ -26,8 +30,8 @@ android { | |||
| } | |||
|
|
|||
| compileOptions { | |||
| sourceCompatibility JavaVersion.VERSION_1_8 | |||
| targetCompatibility JavaVersion.VERSION_1_8 | |||
| sourceCompatibility JavaVersion.VERSION_11 | |||
There was a problem hiding this comment.
Not sure how useful these are, much of the code is already in kotlin.
| kotlin: "org.jetbrains.kotlin:kotlin-gradle-plugin:${versions.kotlin}", | ||
| ksp: "com.google.devtools.ksp:com.google.devtools.ksp.gradle.plugin:${versions.ksp}", | ||
| dokka: "org.jetbrains.dokka:dokka-gradle-plugin:${versions.dokka}", | ||
| mavenPublish: 'com.vanniktech:gradle-maven-publish-plugin:0.18.0', | ||
| spotless: "com.diffplug.spotless:spotless-plugin-gradle:5.11.0", | ||
| shadow: "com.github.jengelman.gradle.plugins:shadow:6.1.0", | ||
| shadow: "com.github.johnrengelman:shadow:8.1.0", |
There was a problem hiding this comment.
This looks questionable - but it is still the same library - upgrade is needed for the new gradle plugin version.
These modules don't seem to use kapt in the gradle. More importantly, having those lines prevented dokka from completing due to gradle complaining about task dependencies when trying to publish the change to local maven
|
I have tested 88c9c0a by successfully building uber's 3 big apps with it. |
|
Thanks for checking internally also. |
This pull request does the following: