check for explicit dependencies

While determining whether to create a no-arg convenience
constructor, we check for both explicit (creatable) dependencies
in addition to unsatisfied sinks to avoid generating incompatible code

compiler/src/main/kotlin/motif/compiler/ScopeImplFactory.kt

@@ -109,7 +109,8 @@ private constructor(private val env: XProcessingEnv, private val graph: Resolved
     }
 
     private fun alternateConstructor(): AlternateConstructor? {
-      if (getDependencyMethodData(scope).isNotEmpty()) {
+      if (getDependencyMethodData(scope).isNotEmpty() ||
+          !scope.dependencies?.methods.isNullOrEmpty()) {
         return null
       }
       return AlternateConstructor(scope.dependenciesClassName)

tests/src/main/java/testcases/KT007_scope_factory_dependencies/GRAPH.txt

@@ -0,0 +1,27 @@
+########################################################################
+#                                                                      #
+# This file is auto-generated by running the Motif compiler tests and  #
+# serves a as validation of graph correctness. IntelliJ plugin tests   #
+# also rely on this file to ensure that the plugin graph understanding #
+# is equivalent to the compiler's.                                     #
+#                                                                      #
+# - Do not edit manually.                                              #
+# - Commit changes to source control.                                  #
+# - Since this file is autogenerated, code review changes carefully to #
+#   ensure correctness.                                                #
+#                                                                      #
+########################################################################
+
+ -------
+| Scope |
+ -------
+
+  ==== Required ====
+
+  ==== Provides ====
+
+    ---- Scope | implicit ----
+      [ Required ]
+      [ Consumed By ]
+
+

tests/src/main/java/testcases/KT007_scope_factory_dependencies/Scope.kt

@@ -0,0 +1,26 @@
+/*
+ * Copyright (c) 2023 Uber Technologies, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package testcases.KT007_scope_factory_dependencies
+
+import motif.Creatable
+
+@motif.Scope
+interface Scope : Creatable<Scope.Dependencies> {
+    // note the absence of string() accessor (e.g. sink) in this scope
+    interface Dependencies {
+        fun string(): String
+    }
+}

tests/src/main/java/testcases/KT007_scope_factory_dependencies/Test.java

@@ -0,0 +1,34 @@
+/*
+ * Copyright (c) 2023 Uber Technologies, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package testcases.KT007_scope_factory_dependencies;
+
+import motif.ScopeFactory;
+import org.jetbrains.annotations.NotNull;
+
+public class Test {
+
+    public static void run() {
+        ScopeFactory.create(
+                Scope.class, new Scope.Dependencies() {
+                    @NotNull
+                    @Override
+                    public String string() {
+                        return "s";
+                    }
+                }
+        );
+    }
+}

tests/src/main/java/testcases/KT007_scope_factory_dependencies/config.pro

@@ -0,0 +1,10 @@
+-libraryjars <java.home>/jmods/java.base.jmod(!**.jar;!module-info.class)
+-dontshrink
+-keep class **Test {
+    public static void run();
+}
+
+-keepnames @motif.Scope interface *
+-keepnames @motif.ScopeImpl class * {
+    <init>(...);
+}