Add ability for aggro cache cleanup to only consider Kraken's disk usage #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| testStats := tally.NewTestScope("", map[string]string{}) | ||
| m.clean(testStats, config, op) | ||
| snapshot := testStats.Snapshot() | ||
| usageGauge, ok := snapshot.Gauges()["disk_usage+"] |
There was a problem hiding this comment.
Not sure where the + comes from. Could this be a bug?
Anton-Kalpakchiev
force-pushed
the
aggro-cleanup-two
branch
from
c332836
to
af94237
Compare
Anton-Kalpakchiev
force-pushed
the
aggro-cleanup-two
branch
from
af94237
to
59471a7
Compare
|
|
||
| // calculateDiskUtil calculates the disk space utilization based on the config. | ||
| // If 'ExcludeOtherServices' is turned on, only this op's utilization of the filesystem is considered. | ||
| func calculateDiskUtil(op base.FileOp, config CleanupConfig) (int, error) { |
There was a problem hiding this comment.
How could I test this?
gkeesh7
reviewed
Nov 28, 2024
| Interval time.Duration `yaml:"interval"` // How often cleanup runs. | ||
| TTI time.Duration `yaml:"tti"` // Time to idle based on last access time. | ||
| TTL time.Duration `yaml:"ttl"` // Time to live regardless of access. If 0, disables TTL. | ||
| ExcludeOtherServices bool `yaml:"exclude_other_services"` // Whether to exclude other services from the disk util calculation. |
There was a problem hiding this comment.
@Anton-Kalpakchiev why are we making this config-driven?
In my opinion, Kraken's cache cleanup should always exclude other services from the disk utilization calculation. I don’t see a scenario where including other services’ disk utilization would improve the cache cleanup behavior.
There was a problem hiding this comment.
The biggest reason is backward compatibility. Other than that, I agree that we don't need the option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #385, the aggressive cache cleanup must be configurable to only consider how much % disk only Kraken uses, when deciding whether to clean the cache.
exclude_other_servicesconfig option