Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to zig 0.13.0 #203

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

chrisirhc
Copy link

@chrisirhc chrisirhc commented Nov 21, 2024

Disclaimer: No idea what I'm doing.

@chrisirhc
Copy link
Author

chrisirhc commented Nov 22, 2024

Hit compilation errors which indicate that threads weren't turned on, when doing bazel test //test/c:test_libc_wasip1_wasm32 (when compiling on my Mac):

In file included from external/_main~toolchains~zig_sdk/lib/libcxx/src/barrier.cpp:9:
external/_main~toolchains~zig_sdk/lib/libcxx/include/barrier:51:4: error: "<barrier> is not supported since libc++ has been configured without support for threads."
   51 | #  error "<barrier> is not supported since libc++ has been configured without support for threads."
      |    ^
external/_main~toolchains~zig_sdk/lib/libcxx/src/condition_variable_destructor.cpp:26:3: error: unknown type name '__libcpp_condvar_t'
   26 |   __libcpp_condvar_t __cv_ = _LIBCPP_CONDVAR_INITIALIZER;
      |   ^
1 error generated.
Target //test/c:test_libc_wasip1_wasm32 failed to build
INFO: Elapsed time: 11.475s, Critical Path: 7.98s
INFO: 2 processes: 2 internal.

More similar errors around pthreads when using 0.14 nightlies (e.g. 0.14.0-dev.2271+f845fa04a) such as:

external/_main~toolchains~zig_sdk/lib/libcxx/include/__thread/support/pthread.h:18:10: error: 'pthread.h' file not found with <angled> include; use "quotes" instead
   18 | #include <pthread.h>
      |          ^
external/_main~toolchains~zig_sdk/lib/libcxx/include/__thread/support/pthread.h:47:9: error: unknown type name 'pthread_mutex_t'
   47 | typedef pthread_mutex_t __libcpp_mutex_t;
      |         ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant