Fix -imports handling aliased imports in source mode
#165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@JacobOaks can you help with #166 and this ? |
r-hang
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
lgtm!
The net effect of this change will be that the gomock generated code should now follow the aliases specified by the -imports mapping. It does seem like this fixes a bug where definedImports is never looked-up by the full path that map is populated with.
|
@r-hang merged master into. Now it needs some maintainer approval |
|
@r-hang I'm not that familiar with the reqs for the internal tests but i believe the latest commit might fix the tests. Can you approve the workflow run ? |
|
@r-hang one more try. I did spend some time now to make sure the CI tooling does the right thing |
|
When will there be a new release ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In source mode, when generating a mock within the same package that uses names from a package that is imported with an alias, the generated mock should obey -imports properly and generate imports with the provided alias.
If the generated code is not using the same aliases as the main filed in a package the go compiler will still happily run but if you want ot use this package as a source in another package where you want to generate a mock, mock will fail because it will not know what to do with a package that is imported with two different names in a source package.
This patch fixes the generation by making
-importshandling do a more correct thing.It can be argued that the correct behavior is, by default use the the same package aliases as the ones in the source file, however that change looked way more invasive and i didn't see a good coverage of tests that would help me make sure the changes worked well.
This is what i found to be the least invasive fix for #166.