Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: grant team lead maintainer permissions on team create #595

Merged
merged 3 commits into from
Nov 29, 2020

Conversation

no-or
Copy link
Contributor

@no-or no-or commented Nov 28, 2020

team: grant team lead maintainer permissions on github team

Closes #547

Details

Before the change:
cmd: /rocket team create <team-name> --lead noor
result: noor is added to lead but not as a maintainer of the team

After the change:
cmd: /rocket team create <team-name> --lead noor
result: noor is added to lead who is also a maintainer of the team

@no-or no-or requested review from a team as code owners November 28, 2020 23:35
@no-or no-or changed the title --lead will make the lead a maintainer feat: grant team lead maintainer permissions on github team Nov 28, 2020
@codecov
Copy link

codecov bot commented Nov 29, 2020

Codecov Report

Merging #595 (142d379) into master (eb95e33) will decrease coverage by 0.10%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #595      +/-   ##
==========================================
- Coverage   93.09%   92.98%   -0.11%     
==========================================
  Files          42       42              
  Lines        2420     2425       +5     
  Branches      323      323              
==========================================
+ Hits         2253     2255       +2     
- Misses        109      112       +3     
  Partials       58       58              
Impacted Files Coverage Δ
interface/github.py 94.35% <40.00%> (-2.29%) ⬇️
app/controller/command/commands/team.py 86.35% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb95e33...142d379. Read the comment docs.

@chuck-sys
Copy link
Collaborator

(Later task): make it so that leads themselves don't have to specify themselves in --leads. I'd be pretty annoyed if I have to do that every time without tab-complete.

@chuck-sys chuck-sys changed the title feat: grant team lead maintainer permissions on github team feat: grant team lead maintainer permissions on team create Nov 29, 2020
@chuck-sys chuck-sys merged commit 3ea85c2 into master Nov 29, 2020
@chuck-sys chuck-sys deleted the team-lead-maintainer branch November 29, 2020 01:06
@chuck-sys chuck-sys restored the team-lead-maintainer branch November 29, 2020 01:23
@chuck-sys chuck-sys deleted the team-lead-maintainer branch November 29, 2020 01:23
@chuck-sys chuck-sys restored the team-lead-maintainer branch November 29, 2020 01:23
chuck-sys pushed a commit that referenced this pull request Nov 29, 2020
no-or added a commit that referenced this pull request Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

team: grant team lead maintainer permissions on github team
2 participants