docs: use full links in README, add warning about GitHub #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #559 +/- ##
=======================================
Coverage 93.81% 93.81%
=======================================
Files 47 47
Lines 2669 2669
Branches 361 361
=======================================
Hits 2504 2504
Misses 108 108
Partials 57 57 Continue to review full report at Codecov.
|
chuck-sys
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of RST features work inconsistently on GitHub - for example, the switch to relative links in the README in #554 broke the links in the README. Since GitHub will still be the main entrypoint (I think) to learning about Rocket 2, making sure everything works here as a GitHub README is important, so I've switched the links back to full URLs and added a warning.
Ticket(s)
Details