temporary fix: disable deletion of existing permissions #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuck-sys
previously approved these changes
Oct 5, 2020
Codecov Report
@@ Coverage Diff @@
## master #540 +/- ##
==========================================
+ Coverage 93.11% 93.43% +0.31%
==========================================
Files 47 47
Lines 2673 2665 -8
Branches 363 360 -3
==========================================
+ Hits 2489 2490 +1
+ Misses 129 119 -10
- Partials 55 56 +1
Continue to review full report at Codecov.
|
bobheadxi
added a commit
that referenced
this pull request
Oct 17, 2020
Drive shares frequently get recreated because we fail to page through all results (we likely have over 100 shares for large folders), and when deletion was enabled (#540) we would also erroneously delete inherited permissions. Both of these issues result in many users receiving duplicate invites whenever Rocket performs a sync (#510, #497). To amend this, we make the following changes: * Permissions listing is now paginated * Permissions listing now happens for direct parents of target folders - permissions discovered in parents are treated as "inherited", and for these permissions we skip both recreation and deletion Co-authored-by: Cheuk Yin Ng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Give a brief description of your changes:
Disables the deletion of existing permissions to resolve #510 temporarily. Longer-term fix is being tracked in the actual problem, #497
Testing
If testing this change requires extra setup, please document it here:
Ticket(s)
Closes #510
(Create a copy of that line for each Github Issue affected,
and replace "Affects" with "Closes" if merging this will close the relevant ticket.)