feat: set teams that automatically grant permissions #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobheadxi
changed the title
bobheadxi
force-pushed
the
permission-teams
branch
from
213dfe7 to
adad1cd
Compare
We sort teams such that special-permissions teams are sync'd last, so that inherited permissions are not overwritten in child folders. This is because we assume that the special-permissions teams have broader access to folders (ie leads get access to a parent folder), at least for Launch Pad.
Codecov Report
@@ Coverage Diff @@
## master #504 +/- ##
==========================================
- Coverage 94.40% 93.62% -0.78%
==========================================
Files 46 46
Lines 2521 2590 +69
Branches 326 342 +16
==========================================
+ Hits 2380 2425 +45
- Misses 92 113 +21
- Partials 49 52 +3
Continue to review full report at Codecov.
|
chuck-sys
requested changes
Sep 28, 2020
Co-authored-by: Cheuk Yin Ng <[email protected]>
2 tasks
chuck-sys
requested changes
Sep 29, 2020
|
Brain keeps being lazy with these edge cases... added some tests: e3a89c5 |
chuck-sys
requested changes
Sep 29, 2020
chuck-sys
approved these changes
Sep 30, 2020
Comment on lines
+743
to
+745
| if user.permissions_level < t['permission']: | ||
| user.permissions_level = t['permission'] | ||
| self.facade.store(user) |
There was a problem hiding this comment.
mmmm yes that sextuple indent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Give a brief description of your changes:
Adds ability for all members in certain teams to get Rocket permissions. Need this to automatically grant everyone in @ubclaunchpad/leads the ability to create teams.
We'll need to add the following to our config:
I know we talked about possibly dropping refresh (#490), but we still need a way to perform the initial sync - I imagine refresh might stay around purely for use cases like this.
There is also a workaround for #497 that I think should work in 35e1209
Testing
If testing this change requires extra setup, please document it here:
Ticket(s)
Closes #496
(Create a copy of that line for each Github Issue affected,
and replace "Affects" with "Closes" if merging this will close the relevant ticket.)