Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger Google Drive shared folder sync on user email edit #498

Merged
merged 3 commits into from
Sep 26, 2020

Conversation

chuck-sys
Copy link
Collaborator

Pull Request

Description

Give a brief description of your changes: When a user puts in their emails, the email actually gets put in! Also syncs all Google Drive folders that the user has access to when the user edits their emails. Refactor the team sync function into another file.

Testing

If testing this change requires extra setup, please document it here: Ask for a test folder to be created (or create your own, nobody will judge). Then start testing.

Ticket(s)

Closes #495
Closes #488

@codecov
Copy link

codecov bot commented Sep 26, 2020

Codecov Report

Merging #498 into master will decrease coverage by 0.18%.
The diff coverage is 45.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #498      +/-   ##
==========================================
- Coverage   93.70%   93.51%   -0.19%     
==========================================
  Files          45       46       +1     
  Lines        2494     2515      +21     
  Branches      321      325       +4     
==========================================
+ Hits         2337     2352      +15     
- Misses        109      114       +5     
- Partials       48       49       +1     
Impacted Files Coverage Δ
interface/gcp_utils.py 29.03% <29.03%> (ø)
app/controller/command/commands/team.py 87.92% <50.00%> (+3.54%) ⬆️
app/controller/command/commands/user.py 100.00% <100.00%> (ø)
app/controller/command/parser.py 96.66% <100.00%> (ø)
utils/slack_parse.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82261dd...547abde. Read the comment docs.

Copy link
Member

@bobheadxi bobheadxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!!

tests/utils/slack_parse_test.py Show resolved Hide resolved
@chuck-sys chuck-sys merged commit 3cbfcc0 into master Sep 26, 2020
@chuck-sys chuck-sys deleted the cheukyin699/#495-email-edit-trigger branch September 26, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

trigger permissions sync when user edits their email setting email seems to be buggy
2 participants