-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update local dev steps, unify permissions in config #485
Conversation
Codecov Report
@@ Coverage Diff @@
## master #485 +/- ##
=======================================
Coverage 94.83% 94.83%
=======================================
Files 44 44
Lines 2403 2403
Branches 303 303
=======================================
Hits 2279 2279
Misses 80 80
Partials 44 44 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general. But man do the docs need updating. We also might need to update recommendations on dev practices (that may or may not coincide with "best practices) regarding running using docker vs pipenv, and how docker may or may not interact badly with local ddb.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Pull Request
Description
Give a brief description of your changes:
Working my way through the local dev guide and a few things have changed on the Slack side of things
Testing
If testing this change requires extra setup, please document it here:
Ticket(s)
n/a
(Create a copy of that line for each Github Issue affected,
and replace "Affects" with "Closes" if merging this will close the relevant ticket.)