Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update local dev steps, unify permissions in config #485

Merged
merged 10 commits into from
Sep 24, 2020

Conversation

bobheadxi
Copy link
Member

Pull Request

Description

Give a brief description of your changes:

Working my way through the local dev guide and a few things have changed on the Slack side of things

Testing

If testing this change requires extra setup, please document it here:

Ticket(s)

n/a

(Create a copy of that line for each Github Issue affected,
and replace "Affects" with "Closes" if merging this will close the relevant ticket.)

@bobheadxi bobheadxi requested a review from chuck-sys September 24, 2020 11:17
@bobheadxi bobheadxi requested review from a team as code owners September 24, 2020 11:17
@bobheadxi bobheadxi changed the title docs: add slack scopes, update some steps docs: update local dev steps, unify permissions in config Sep 24, 2020
@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #485 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #485   +/-   ##
=======================================
  Coverage   94.83%   94.83%           
=======================================
  Files          44       44           
  Lines        2403     2403           
  Branches      303      303           
=======================================
  Hits         2279     2279           
  Misses         80       80           
  Partials       44       44           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6186100...98da49f. Read the comment docs.

Copy link
Collaborator

@chuck-sys chuck-sys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general. But man do the docs need updating. We also might need to update recommendations on dev practices (that may or may not coincide with "best practices) regarding running using docker vs pipenv, and how docker may or may not interact badly with local ddb.

docs/Config.md Show resolved Hide resolved
docs/LocalDevelopmentGuide.md Show resolved Hide resolved
docs/LocalDevelopmentGuide.md Show resolved Hide resolved
Copy link
Collaborator

@chuck-sys chuck-sys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bobheadxi bobheadxi merged commit 9f04e7d into master Sep 24, 2020
@bobheadxi bobheadxi deleted the update-setup branch September 24, 2020 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants