Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook up real time bid updates to frontend #79

Merged
merged 4 commits into from
Apr 12, 2024
Merged

Hook up real time bid updates to frontend #79

merged 4 commits into from
Apr 12, 2024

Conversation

kevinrczhang
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Add any screenshots of the change.

Fixes # (ticket #)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

/assignme

backend/auction/views.py Outdated Show resolved Hide resolved
@kevinrczhang
Copy link
Contributor Author

Beautiful.
Of course pipelines fail again.

useEffect(() => {
const chatSocket = new WebSocket(wsURL);

chatSocket.onmessage = function(event) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinrczhang Use arrow function instead to fix it

@kevinrczhang kevinrczhang merged commit 79c71f9 into main Apr 12, 2024
2 checks passed
@kevinrczhang kevinrczhang deleted the bid-updates branch April 12, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants