Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update, delete, and get auction endpoints #14

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

ltan02
Copy link
Member

@ltan02 ltan02 commented Nov 8, 2023

Description

Created endpoints for updating, deleting, and fetching a single auction.

Fixes # (ticket #)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@ltan02 ltan02 requested a review from kevinrczhang November 8, 2023 00:34
@ltan02 ltan02 self-assigned this Nov 8, 2023
Copy link
Contributor

@kevinrczhang kevinrczhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, will have to create a task that adds user-authorization so that only certain types of users can access these endpoints.

@ltan02 ltan02 merged commit 79d323f into main Nov 8, 2023
1 check passed
@ltan02 ltan02 deleted the lance/create-endpoint-update-auction branch February 3, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants