Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diffing Algorithm #13

Merged
merged 36 commits into from
Nov 22, 2024
Merged

Diffing Algorithm #13

merged 36 commits into from
Nov 22, 2024

Conversation

AlexLuo602
Copy link
Contributor

  • Not ready to merge, submitting for reference for now

andrew-fenton and others added 30 commits November 5, 2024 09:56
@andrew-fenton
added stub functions
d12f125
@andrew-fenton
implemented setup
e0d2f88
@andrew-fenton
abstracted out hashing functions
3129226
@andrew-fenton
cleaned up file
c1b2892
@andrew-fenton
skeleton for diffing algo
c9ce287
@andrew-fenton
changed function name
b74659c
@andrew-fenton
changed order of functions for readability
7f1a2b8
@andrew-fenton
added tests for updating metadata and state
9ac2fdc
@AlexLuo602
code refactoring, align diffing_processor with new engineering tasks
7eaefca
@andrew-fenton
fixed test bug
8db0141
@andrew-fenton
remove pycache
578df7b
@andrew-fenton
changed directory names
1b1933a
@AlexLuo602
Merge branch 'main' of https://github.com/ubclaunchpad/localization i…
48e1220 
…nto diffing_algorithm
@AlexLuo602
Created diffing algorithm draft
0ae27c8
@AlexLuo602
Changed formatting of diff results
40f8f39
@AlexLuo602
standardized diffing test folders to allow for more complex tests to …
6b29f5d 
…be directly expanded onto existing code
@AlexLuo602
remove excessive folders after diffing test
22c194f
@AlexLuo602
Move the diff test folders into its own folder to prevent clashing wi…
c4c21db 
…th test translations folder
@andrew-fenton
dump all newly computed hashes instead of only pushing updates to met…
6ffc187 
…adata
@AlexLuo602
automated tests
dcdf23d
@andrew-fenton
disabled dirsync logging
fc74577
@andrew-fenton
added dummy folders for testing
8b6d913
@andrew-fenton
revert dummy folders
0f8eae8
@andrew-fenton
added dummy test folders (this time they work)
8d0d90e
@andrew-fenton
added updating metadata tests
c6855ff
@andrew-fenton
added sync test
9910118
@andrew-fenton
Merge branch 'main' into diffing_algorithm
b361e56
@kevinrczhang
Merge branch 'main' into diffing_algorithm
624f42b
@kevinrczhang
merge into main, update ci yaml
23ef39a
@kevinrczhang
update pipeline
a4ca66e
kevinrczhang
kevinrczhang reviewed Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@kevinrczhang kevinrczhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will review thoroughly tomorrow, these are just some small nits i've noticed so far

i18nilize/src/internationalize/diffing_processor.py Outdated Show resolved Hide resolved
i18nilize/src/internationalize/languages/korean.json Show resolved Hide resolved
@andrew-fenton andrew-fenton changed the title Diffing Algorithm Draft Diffing Algorithm Nov 20, 2024
@kevinrczhang kevinrczhang merged commit 8812162 into main Nov 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinrczhang kevinrczhang kevinrczhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexLuo602 @kevinrczhang @andrew-fenton