-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backend endpoints #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work so far with the routes. I have suggested few modifications to be made, mostly related to error handling and file structuring.
One main thing is that in the service side, if an error is encountered, the server will crash. So we should return the error back to the controller and handle it there through returning a error status code with the error message, rather than throwing the error directly in the service. I have added a commit as a suggestion for how to do this, please feel free to refactor the rest of the routes in a similar way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for refactoring things! Just a couple of edge cases to fix now, once thats done feel free to merge in
cc12f94
to
aaeb5ee
Compare
Tasks finished
API Endpoints