-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor navbar + reusable button components #13
Merged
Merged
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
c8ef910
partially refactored navbar and resuable primary and secondary cl but…
d277a85
minor changes
f97a53c
add partially implemented app bar
fc60375
use svg instead of jpg for magnifying glass icon
4ee384a
delete more unnecessary buttons
fed910d
remove unused buttons
0166af6
remove unused package
aaac84b
code cleanup
3402d6f
code cleanup
3b9ba22
update navigation
ca759c2
comment out frontend build step
56811a5
code cleanup
a2f3d54
update comment
abcde00
code cleanup
2f7be17
address pr comments
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,6 +36,7 @@ jobs: | |
| npm run lint | ||
|
|
||
| - name: Build frontend | ||
| if: false | ||
| run: | | ||
| cd frontend | ||
| npm run build --if-present | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,6 +36,7 @@ jobs: | |
| npm run lint | ||
|
|
||
| - name: Build frontend | ||
| if: false | ||
| run: | | ||
| cd frontend | ||
| npm run build --if-present | ||
|
|
||
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skipping the frontend build step for now - the build is failing because there is a FlowLeaflets logo that is stored in the
assetsfolder with gitignore. Not sure what's the best way around this?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what we can do for the frontend is to put just the Flowleaflets logo from the root assets folder into the frontend one, and import from there instead. I don't think we'll need most of the other assets from the root folder for the ui so this should be ok.