Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettified codebase #348

Merged
merged 13 commits into from
Jan 10, 2023
Merged

Prettified codebase #348

merged 13 commits into from
Jan 10, 2023

Conversation

AnimeAllstar
Copy link
Member

@AnimeAllstar AnimeAllstar commented Jan 10, 2023

  • setup prettier config file for the repo
  • ran prettier on the entire repo
  • updated docs
  • added GitHub Action that creates a commit on PRs to master if the code isn't prettified. (We could do this in the same commit, but I thought it'd be better to have a different commit). This happens before the merge when all the deploy preview tests are running. If you add a second commit with bad formatting to a live PR, it'll make another commit to the PR formatting your code.

You will have to run yarn install when you pull changes to run prettier locally.

Let me know what y'all think. We can definitely update the prettier config if there are any changes that should be made.

closes #324

@AnimeAllstar AnimeAllstar requested a review from a team January 10, 2023 07:48
Copy link
Member

@kewbish kewbish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a bit of a chicken and egg situation here: I can't run the GitHub action on this repo if it hasn't been merged here, but I saw on your personal fork that you've tested it and it works, so I'm comfortable with approving.

This should be revertible if things go wrong (and if they go wrong, Netlify won't build the latest version and will continue to serve the old version) so we should be safe. Netlify successfully built this PR, so there shouldn't be any issues.

I left a couple nits below, feel free to address or leave them.

Thanks so much for taking this on!

.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.nvmrc Show resolved Hide resolved
README.md Show resolved Hide resolved
@AnimeAllstar AnimeAllstar merged commit e59c35a into ubccsss:master Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prettifying the codebase
2 participants