-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prettified codebase #348
Prettified codebase #348
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a bit of a chicken and egg situation here: I can't run the GitHub action on this repo if it hasn't been merged here, but I saw on your personal fork that you've tested it and it works, so I'm comfortable with approving.
This should be revertible if things go wrong (and if they go wrong, Netlify won't build the latest version and will continue to serve the old version) so we should be safe. Netlify successfully built this PR, so there shouldn't be any issues.
I left a couple nits below, feel free to address or leave them.
Thanks so much for taking this on!
You will have to run
yarn install
when you pull changes to run prettier locally.Let me know what y'all think. We can definitely update the prettier config if there are any changes that should be made.
closes #324