Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lab notebook components #33

Merged
merged 49 commits into from
Sep 30, 2023
Merged

Lab notebook components #33

merged 49 commits into from
Sep 30, 2023

Conversation

daniel-panhead
Copy link
Member

ezpz

@daniel-panhead
Copy link
Member Author

Still missing: smooth animation of mobile nav dropdown, scroll dots for mobile double column, fix super evil hack for smooth expand/collapse of bubbles

@daniel-panhead
Copy link
Member Author

Table is pretty bad but will fix later :D

@daniel-panhead
Copy link
Member Author

ok merge pls

@daniel-panhead
Copy link
Member Author

okay now merge pls

@daniel-panhead
Copy link
Member Author

Ok hopefully this is the last time

Copy link
Collaborator

@IcedTea2K IcedTea2K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfecto! Everything is amazing-balls.

This should be a side-by-side picture instead. Don't forget to fix the NOTEBOOK.md to include div and other tags in the if necessary.
image

There should be a bit more padding to the left of the table of contents
image

Though the drop down kinda blend into the background a bit. It's a bit hard on the eye for some reason
image

Also, the footer is moving with the references/bottom bubble. UX might be a bit annoying if they accidentally clicked collapsed
image

Copy link
Collaborator

@IcedTea2K IcedTea2K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the footer, we don't have to worry about it yet!

Copy link
Collaborator

@IcedTea2K IcedTea2K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good now. We could add this to the backlog for now, but I think the drop down for sub-pages should be aligned with the previous drop down. For example, enzyme activity assay should be on the same line as enzymosome.
image

@daniel-panhead daniel-panhead merged commit 18d1659 into main Sep 30, 2023
@daniel-panhead daniel-panhead deleted the lab-notebook-components branch September 30, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants