flush HDF5 after RAT operations #71
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gillins yes, that would make sense to include. I don't think there was any reason I didn't include it. Probably just an oversight. |
|
Creates a huge performance regression when calculating neighbours. Working on another solution... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@petebunting just chasing a weird corruption when repeatedly opening and adding to a RAT. I noticed you issue the
keaImg->flush(H5F_SCOPE_GLOBAL);call whenever doing an image operation but not with the RAT. Does it make sense to be also doing this here?I'll have to wait until the conda forge kealib 1.6.0 migration has finished to properly test what I'm seeing.