Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Kealib CMake package with Kealib::Kealib #47

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Dec 9, 2023

For #31 (comment):

Enable the following usage pattern:

find_package(Kealib CONFIG REQUIRED)
target_link_libraries(main PRIVATE Kealib::Kealib)
  • Independent of Kealib library linkage.
  • Package name consist with project name.
  • Target name and namespace consistent with package name.

Enable the following usage pattern (untested):

add_subdirectory(my-kealib-subdir)
target_link_libraries(main PRIVATE Kealib::Kealib)

@dg0yt dg0yt marked this pull request as ready for review December 9, 2023 12:46
@gillins
Copy link
Member

gillins commented Dec 10, 2023

@petebunting any objections to this?

@petebunting
Copy link
Collaborator

I have no objections.

@gillins
Copy link
Member

gillins commented Dec 11, 2023

Confirmed not to break GDAL 3.8.1.

@gillins gillins merged commit 659d893 into ubarsc:master Dec 11, 2023
2 checks passed
@dg0yt dg0yt deleted the kealib-config branch December 19, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants