Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double strand modular-scale() #112

Open
ldexterldesign opened this issue Jun 18, 2013 · 12 comments
Open

Double strand modular-scale() #112

ldexterldesign opened this issue Jun 18, 2013 · 12 comments

Comments

@ldexterldesign
Copy link

Hey,

I just helped push this through in http://bourbon.io/docs/#modular-scale :
thoughtbot/bourbon#175
thoughtbot/bourbon@5bdaa07

I'd really like to see double strand functionality in http://typeplate.com/ too

Yours hopefully,

@grayghostvisuals
Copy link
Contributor

If you would like to strictly build this as a function for our Sass port I'd be willing to cater the idea. What do you think @zakkain ?

@ldexterldesign
Copy link
Author

*Currently trying to shoehorn thoughtbot/bourbon@5bdaa07 into http://typeplate.com/ , but it's not going well :Z *

@grayghostvisuals
Copy link
Contributor

Let's get Zak's opinion too before you go any further. Also a reminder if you do go through with this to make sure you work on it through a sep branch per our README.

@ldexterldesign
Copy link
Author

NP, let me know ;)

Kind thanks,

PS I don't believe thoughtbot/bourbon#175 outputs rem/px fallbacks functionality, which is a nice feature in yours (I'll ping https://github.com/plapier a line now and hopefully he can corroborate that?)

@grayghostvisuals
Copy link
Contributor

I'd like to see an example of the code in this thread as well before proceeding with it in the project itself. I've also noted in the new README of the development branch the Modular Scale gem by @scottkellum which I think is very easy to incorporate for Authors that use the Sass port of Typeplate. If they already have Sass most likely they have Ruby and Gems so to install another Gem for Scott's modular scale project is no big deal IMO over having it hard coded in the project.

@caycefischer
Copy link
Member

​Personally I want to avoid a dependency on any more gems. The more
vanilla Sass we have, the better.

@caycefischer
Copy link
Member

As much as I like the way the gem works, I actually use Tim Brown's modularscale.com instead, I like to get it in a browser window and copy-paste. That's how we got the default values to plug into our own function, we can link to it as an easy option too.

It should be easy to rip ours out and use Scott's gem, either way. CHOICE!

opensource

@scottkellum
Copy link

@zakkain Until Sass natively supports exponents my modular-scale gem will only be installable as a gem or though Bower on Compass. I have some Ruby in there to efficiently add that functionality and support non integers on the scale.

IMO dependencies (gems or Bower) are really easy to manage and way easier to update than copy/paste. Most projects I try to avoid Ruby so copy/paste works but yeah, happy to see Bourbon is supporting double standards now.

@grayghostvisuals
Copy link
Contributor

@scottkellum

IMO dependencies (gems or Bower) are really easy to manage and way easier to update than copy/paste.

So true which is why I have your modular scale project linked in the new docs of our dev branch atm. No need to remake it when you do a great job as it is. If authors want it then they can install the gem. No dependencies. Just little packages to add on as I see it. 🤘

@caycefischer
Copy link
Member

The dependency model does look a lot easier, but I'm still clinging to the old Notepad copy-paste ways a little bit ;) 👴

@grayghostvisuals
Copy link
Contributor

@zakkain You are the Devil!

@ldexterldesign
Copy link
Author

@zakkain I guess I'll have to do the same with 2 scales ( http://modularscale.com/ ) until this feature gets integrated into http://typeplate.com/ - which ever method you go for +1 for double strand and rem output ;)

Cheers,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants