Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line 5: Function golden-ratio is missing argument $value.? #48

Closed
ldexterldesign opened this issue Jun 13, 2013 · 9 comments
Closed

Line 5: Function golden-ratio is missing argument $value.? #48

ldexterldesign opened this issue Jun 13, 2013 · 9 comments

Comments

@ldexterldesign
Copy link

Hey,

Thanks for your work on this feature - excited to get playing with it ( https://twitter.com/ldexterldesign/status/345131467938091008 ), however I'm getting the following error on start up - any help?

screen shot 2013-06-13 at 12 00 14

Yours hopefully,

@ldexterldesign
Copy link
Author

Ahh, I've just realised you need http://compass-style.org/ for this, correct?

Cheers,

@floscr
Copy link

floscr commented Jun 19, 2013

I've got the same issue, but only if I also use bourbon.

@scottkellum
Copy link
Member

You need to use this with Compass

@scottkellum
Copy link
Member

It says “Compass” in the install process, is that not clear enough?

@floscr
Copy link

floscr commented Jun 19, 2013

I'm using compass, but i also like to @import bourbon to compass…

@scottkellum
Copy link
Member

@artish Bourbon has a modular-scale function as well with the same name: http://bourbon.io/docs/#modular-scale

There will definitely be conflicts, try @importing modular-scale below your bourbon import.

Let me know if that helps, reopening until settled

@scottkellum scottkellum reopened this Jun 19, 2013
@floscr
Copy link

floscr commented Jun 19, 2013

Oh gosh! I didn't know that bourbon had a similar function. Sorry about that!

I already have the modular-scale import below the bourbon import and compass passes me an error.

@scottkellum
Copy link
Member

Looking further into it there is no easy way to fix this as my codebase currently exists. Looks like Bourbon is doing some things with the golden ratio function that aren’t compatible with what I am doing.

You will have to selectively import Bourbon or avoid modular-scale.

Closing without further action.

@ldexterldesign
Copy link
Author

@artish you can use the Bourbon update here thoughtbot/bourbon#175

Count yourself lucky - I have 3 versions of the modular-scale function in my project ( typeplate/typeplate.github.io#112 )! :(

Best regards,

PS It would be useful if there was a universal modular scale everyone could agree on with:

  • Double strand
  • rem output/px fallback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants