-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Line 5: Function golden-ratio is missing argument $value.? #48
Comments
Ahh, I've just realised you need http://compass-style.org/ for this, correct? Cheers, |
I've got the same issue, but only if I also use bourbon. |
You need to use this with Compass |
It says “Compass” in the install process, is that not clear enough? |
I'm using compass, but i also like to @import bourbon to compass… |
@artish Bourbon has a modular-scale function as well with the same name: http://bourbon.io/docs/#modular-scale There will definitely be conflicts, try @importing modular-scale below your bourbon import. Let me know if that helps, reopening until settled |
Oh gosh! I didn't know that bourbon had a similar function. Sorry about that! I already have the modular-scale import below the bourbon import and compass passes me an error. |
Looking further into it there is no easy way to fix this as my codebase currently exists. Looks like Bourbon is doing some things with the golden ratio function that aren’t compatible with what I am doing. You will have to selectively import Bourbon or avoid modular-scale. Closing without further action. |
@artish you can use the Bourbon update here thoughtbot/bourbon#175 Count yourself lucky - I have 3 versions of the modular-scale function in my project ( typeplate/typeplate.github.io#112 )! :( Best regards, PS It would be useful if there was a universal modular scale everyone could agree on with:
|
Hey,
Thanks for your work on this feature - excited to get playing with it ( https://twitter.com/ldexterldesign/status/345131467938091008 ), however I'm getting the following error on start up - any help?
Yours hopefully,
The text was updated successfully, but these errors were encountered: