add Doc.textWithLine for controlling how lines are parsed #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnynek
changed the title
|
looks like no one wanted to review this one. I'm confident in the tests I added, so I'm going to merge. |
johnynek
added a commit
that referenced
this pull request
Jan 2, 2025
* add Doc.textWithLine for constrolling how lines are parsed * scalafmt * fix test, add another law
|
Yeah, sorry -- it looks fine to me, but I don't know enough about the library to have an informed opinion. IMO merging was the right thing to do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doc.text forces a single version of line parsing, and it's the only way to convert a
Stringto aDoc. Sometimes, however, you might wanthardLines and notlinewhich when flattened becomes a space.