-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add driver fields to the connection open request #540
Draft
dmitrii-ubskii
wants to merge
17
commits into
typedb:development
Choose a base branch
from
dmitrii-ubskii:handshake
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Review ChecklistDo not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed. Trivial Change
Code
Architecture
|
dmitrii-ubskii
changed the title
Handshake
Add driver fields to the connection open request
Dec 14, 2023
dmitrii-ubskii
force-pushed
the
handshake
branch
from
December 14, 2023 12:39
94c1c7d
to
268b46c
Compare
dmitrii-ubskii
added
type: feature
priority: blocker
priority: medium
x: do not merge
and removed
priority: blocker
labels
Dec 14, 2023
flyingsilverfin
force-pushed
the
development
branch
from
January 15, 2024 14:23
1fb9312
to
f04d10c
Compare
We preserve this PR until 3.0.0 as it breaks backward compatibility, and we don't want to break it until 3.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage and product changes
Added and populated driver name and version fields to the Connection.Open request payload.
Note: despite proto3 being able to handle added fields, due to a library packaging issue, older versions of TypeDB cannot handle new fields. This means that this change breaks compatibility with TypeDB server 2.25.x and earlier.