-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-write using Volar: initially only supporting .gts #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get empty server running basic TS feature parity cleanup tmp notes notes and fidgets get something running on volar 2 too complicated apha 14 2.0 get something compiling again wip use mdx as example. not vue it builds volar 2.0.1 get .gts autocomplete working get something sorta showing up in Volar Labs fix: use consistent lsp packages absorb portions of vsc-ember-syntax bump volar get transormed IR showing up in labs valid leaf tokens mapping to each other fix comment decode avoid fileId hacks cleanup add gjs support cleanup volar 2.0.4 getting solo .hbs type-checking working comments bump disable linting
Update to Volar 2.3
I'm merging this with red status, with the understanding that we're not going to release a stable v2 until the tests are green, and some more features are implemented (I've talked with @machty about this, and the goal here is to just get folks trying out Volar for some early feedback). Next, I'm going to set up unstable releases like we have on embroider. |
NullVoxPopuli
added
enhancement
New feature or request
breaking
A breaking change
labels
Jun 20, 2024
This was referenced Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rebuilds Glint atop Volar.js, a language tooling framework used by Vue and many others.
The focus for this PR is to get Volar working with initial support only for .gts/.gjs files, i.e. a modern Polaris-edition Ember.js app. Support for classic two-file components will be investigated at a later date (but I am optimistic we can support that too).
Gameplan / TODO
vsc-ember-syntax
Transfer to ember-tooling lifeart/vsc-ember-syntax#72Likely save for future PR
{{ @glint-expect-error }}
and related directives workingdata
objects on nested embedded codes https://discord.com/channels/1192759067815464990/1252021970443440128/1252298644695158874