Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use gjs as codefence lang #725

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

IgnaceMaes
Copy link
Contributor

Glimmer JS/TS syntax highlighting support was added to GitHub a couple of months ago. This PR uses that lang for codefences where <template> tag is being used.

@NullVoxPopuli
Copy link
Contributor

gjs works:

const two = 2;

<template>
  {{two}}
</template>

gts:

const two = 2;

<template>
  {{two}}
</template>

glimmer-ts:

const two = 2;

<template>
  {{two}}
</template>

did we misconfigure something in linguist?

@IgnaceMaes
Copy link
Contributor Author

It's because gts already existed prior to us adding GJS/GTS support.

In search you can see it detects it as Gerber image:

Screenshot 2024-06-17 at 14 09 40

https://github.com/search?q=%28path%3A*.gts%29+AND+%28content%3A%3Ctemplate%3E+OR+content%3A%40glimmer+OR+content%3A%40ember%29+NOT+is%3Afork&type=code

Not sure if this can be changed, or if GitHub works with first come, first served.

@NullVoxPopuli
Copy link
Contributor

hmm. that's silly

@NullVoxPopuli NullVoxPopuli merged commit a4162f0 into typed-ember:main Jun 20, 2024
4 of 6 checks passed
@NullVoxPopuli NullVoxPopuli added the documentation Improvements or additions to documentation label Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants