feat: drop support for classic component layout (#721)

* feat: drop support for classic component layout * Delete component with classicly resolved template --------- Co-authored-by: NullVoxPopuli <[email protected]>
typed-ember · Jul 9, 2024 · 9efe7b1 · 9efe7b1
1 parent e8d1c9a
commit 9efe7b1
Show file tree

Hide file tree

Showing 9 changed files with 0 additions and 59 deletions.
diff --git a/packages/environment-ember-loose/-private/environment/index.ts b/packages/environment-ember-loose/-private/environment/index.ts
@@ -62,9 +62,6 @@ export default function emberLooseEnvironment(
             templatePath.replace(REGEXES.POD_TEMPLATE, '/controller.ts'),
             templatePath.replace(REGEXES.POD_TEMPLATE, '/route.ts'),
           );
-        } else if (templatePath.includes('/templates/components/')) {
-          // Classic component
-          candidates.push(colocatedTsScriptPath.replace('/templates/components/', '/components/'));
         } else if (templatePath.includes('/templates/')) {
           // Classic controller/route
           candidates.push(

diff --git a/packages/environment-ember-loose/__tests__/environment.test.ts b/packages/environment-ember-loose/__tests__/environment.test.ts
@@ -69,14 +69,6 @@ describe('Environments: Ember Loose', () => {
       '/route.js',
     ]);
 
-    // Classic component
-    expect(env?.getPossibleScriptPaths('/templates/components/hello.hbs')).toEqual([
-      '/templates/components/hello.ts',
-      '/templates/components/hello.js',
-      '/components/hello.ts',
-      '/components/hello.js',
-    ]);
-
     // Classic controller/route
     expect(env?.getPossibleScriptPaths('/templates/hello.hbs')).toEqual([
       '/templates/hello.ts',

diff --git a/test-packages/ts-ember-app/app/components/foo.hbs b/test-packages/ts-ember-app/app/components/foo.hbs
@@ -20,8 +20,6 @@
 
 <Baz />
 
-<Qux />
-
 <this.MaybeComponent @arg="hi" />
 
 {{! @glint-expect-error: missing required arg }}

diff --git a/test-packages/ts-ember-app/app/components/qux.ts b/test-packages/ts-ember-app/app/components/qux.ts
diff --git a/test-packages/ts-ember-app/app/templates/components/qux.hbs b/test-packages/ts-ember-app/app/templates/components/qux.hbs
diff --git a/test-packages/ts-ember-app/tests/integration/components/qux-test.ts b/test-packages/ts-ember-app/tests/integration/components/qux-test.ts
diff --git a/test-packages/ts-ember-preview-types/app/components/foo.hbs b/test-packages/ts-ember-preview-types/app/components/foo.hbs
@@ -20,8 +20,6 @@
 
 <Baz />
 
-<Qux />
-
 <this.MaybeComponent @arg="hi" />
 
 {{! @glint-expect-error: missing required arg }}

diff --git a/test-packages/ts-ember-preview-types/app/components/qux.ts b/test-packages/ts-ember-preview-types/app/components/qux.ts
diff --git a/test-packages/ts-ember-preview-types/app/templates/components/qux.hbs b/test-packages/ts-ember-preview-types/app/templates/components/qux.hbs
-Original file line number
+Diff line change
@@ Expand Up / @@ -20,8 +20,6 @@ @@
     <Baz />
-    <Qux />
     <this.MaybeComponent @arg="hi" />
     {{! @glint-expect-error: missing required arg }}
@@ Expand Down @@