Migrate from Jenkins -> GitHub Actions #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Didericis
reviewed
Oct 12, 2021
| - name: Install requirements from all requirements.txt files | ||
| run: | | ||
| INSTALL_COMMAND="pip install" | ||
| for file in sykle/plugins/**/requirements.txt; do |
There was a problem hiding this comment.
👍 nice little bash snippet
Didericis
previously approved these changes
Oct 12, 2021
Didericis
reviewed
Oct 12, 2021
.github/workflows/cd.yml
Outdated
| @@ -0,0 +1,15 @@ | |||
| name: CD | |||
There was a problem hiding this comment.
@emmabh this can actually be removed; originally, when we had most of our projects on jenkins, this would ensure that a push to this repo would automatically update jenkins so that the internal syk command available on that jenkins instance was up to date. So the sudo make install command that was previously running on jenkins was just for that instance.
There was a problem hiding this comment.
a-ha! that makes total sense, I was wondering why we had a cd that didn't go anywhere but it all makes sense now lol.
Didericis
suggested changes
Oct 12, 2021
Didericis
approved these changes
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NB: had to lock in a version of gitdb2 that was compatible with GitPython