Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(text-field): ensure cleanup logic runs when element is disconnected #776

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(text-field): ensure cleanup logic runs when element is disconnected #776

wants to merge 1 commit into from

Conversation

DRiFTy17
Copy link
Collaborator

@DRiFTy17 DRiFTy17 commented Jan 2, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added/updated: N
  • Docs have been added/updated: N
  • Does this PR introduce a breaking change? N
  • I have linked any related GitHub issues to be closed when this PR is merged? N

Describe the new behavior?

Add missing call to disconnectedCallback() to ensure that cleanup logic properly runs when the element is removed from the DOM.

@DRiFTy17 DRiFTy17 added patch Increment the patch version when merged skip-release Preserve the current version when merged labels Jan 2, 2025
@DRiFTy17 DRiFTy17 requested a review from a team as a code owner January 2, 2025 21:03
@stackblitz StackBlitz
Copy link

stackblitz bot commented Jan 2, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samrichardsontylertech samrichardsontylertech samrichardsontylertech approved these changes

Assignees
No one assigned
Labels
patch Increment the patch version when merged skip-release Preserve the current version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DRiFTy17 @samrichardsontylertech