Slottable Custom Icons for FieldMultiple's Buttons #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ended up copying FieldMultiple to my own project in order to add the desired slots for allowing custom icons to be used as I was worried the x-circle icon for the delete button would be misinterpreted in the context of my form while I definitely wanted an icon to keep the button width small in the layout I'm using.
I was reluctant to publish the changes to this repo as I wasn't sure if we wanted the ability to customize the icons in other contexts or if we wanted to restrict that from possibly confusing things. Creating pull request now in case it's something we're OK with here in hopes that I can just import directly from here and automatically pull in future updates to FieldMultiple rather than manually merging them into that project's custom copy.