Merge pull request input-output-hk#1378 from input-output-hk/ensemble…

…/fix-explorer-switch-aggregator Fix explorer switch aggregator infinite loop
txpipe · Nov 30, 2023 · 426b764 · 426b764
2 parents a659cc7 + 8343f6f
commit 426b764
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 9 deletions.
diff --git a/mithril-explorer/package.json b/mithril-explorer/package.json
@@ -1,6 +1,6 @@
 {
   "name": "mithril-explorer",
-  "version": "0.4.5",
+  "version": "0.4.6",
   "private": true,
   "scripts": {
     "dev": "next dev",

diff --git a/mithril-explorer/src/app/page.js b/mithril-explorer/src/app/page.js
@@ -60,18 +60,21 @@ export default function Explorer() {
     }
 
     dispatch(updatePoolsForAggregator(selectedAggregator));
-  }, [selectedAggregator, router, searchParams, dispatch]);
+  }, [selectedAggregator]); // eslint-disable-line react-hooks/exhaustive-deps
 
   // Allow navigation to work (previous, next)
   useEffect(() => {
-    if (isUpdatingAggregatorInUrl) {
-      setIsUpdatingAggregatorInUrl(false);
-    } else {
-      const aggregatorInUrl = searchParams.get("aggregator");
+    function allowNavigation() {
+      if (isUpdatingAggregatorInUrl) {
+        setIsUpdatingAggregatorInUrl(false);
+      } else {
+        const aggregatorInUrl = searchParams.get("aggregator");
 
-      dispatch(selectAggregator(aggregatorInUrl));
+        dispatch(selectAggregator(aggregatorInUrl));
+      }
     }
-  }, [searchParams, dispatch, isUpdatingAggregatorInUrl]);
+    allowNavigation();
+  }, [searchParams]); // eslint-disable-line react-hooks/exhaustive-deps
 
   return (
     <Stack gap={3}>

diff --git a/mithril-explorer/src/app/registrations/page.js b/mithril-explorer/src/app/registrations/page.js
@@ -90,7 +90,7 @@ export default function Registrations() {
     } else {
       setCurrentError(error);
     }
-  }, [searchParams, dispatch]);
+  }, [searchParams]); // eslint-disable-line react-hooks/exhaustive-deps
 
   function getNoRegistrationsMessage() {
     if (currentEpoch === registrationEpoch) {