Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial geography support #4

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Add initial geography support #4

merged 1 commit into from
Jul 1, 2024

Conversation

wchargin
Copy link
Contributor

@wchargin wchargin commented Jul 1, 2024

This follows the form of a recent commit to pgx-geos for the same functionality.

twpayne
twpayne reviewed Jul 1, 2024
View reviewed changes
Copy link
Owner

@twpayne twpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for another excellent PR!

Just one minor nit. Once you've made the changes, please could you squash all the commits in to one with the message:

feat: add initial geography support

pgxgeom_test.go Outdated Show resolved Hide resolved
wchargin
wchargin commented Jul 1, 2024
View reviewed changes
Copy link
Contributor Author

@wchargin wchargin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Updated and squashed.

pgxgeom_test.go Outdated Show resolved Hide resolved
@twpayne
Copy link
Owner

twpayne commented Jul 1, 2024

Following #3, this PR needs a little conflict resolution. Would you be able to do it?

@wchargin
Copy link
Contributor Author

wchargin commented Jul 1, 2024

Certainly; done.

@twpayne twpayne merged commit ae49173 into twpayne:master Jul 1, 2024
2 checks passed
@wchargin wchargin deleted the geography branch July 1, 2024 23:29
@wchargin
Copy link
Contributor Author

wchargin commented Jul 1, 2024

Thanks!

@twpayne
Copy link
Owner

twpayne commented Jul 1, 2024

Thank you! I've tagged v0.0.2 with this PR and #3 included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twpayne twpayne twpayne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wchargin @twpayne