Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github, txn docs: use Kafka 3.6, avoid KAFKA-15653, doc deprecated option #608

Merged
merged 1 commit into from
Oct 23, 2023
Merged

.github, txn docs: use Kafka 3.6, avoid KAFKA-15653, doc deprecated option #608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/lint-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-go@v3
with:
go-version: 1.20.3
go-version: 1.21.3
- uses: golangci/golangci-lint-action@v3
with:
version: latest
Expand All @@ -34,10 +34,10 @@ jobs:
needs: golangci
runs-on: ubuntu-latest
name: "integration test kafka"
container: golang:1.20.3
container: golang:1.21.3
services:
kafka:
image: bitnami/kafka:3.5
image: bitnami/kafka:latest
ports:
- 9092:9092
env:
Expand All @@ -47,6 +47,7 @@ jobs:
KAFKA_CFG_LISTENERS: PLAINTEXT://:9092,CONTROLLER://:9093
KAFKA_CFG_LISTENER_SECURITY_PROTOCOL_MAP: CONTROLLER:PLAINTEXT,PLAINTEXT:PLAINTEXT
KAFKA_CFG_CONTROLLER_QUORUM_VOTERS: [email protected]:9093
KAFKA_CFG_TRANSACTION_PARTITION_VERIFICATION_ENABLE: false
# Set this to "PLAINTEXT://127.0.0.1:9092" if you want to run this container on localhost via Docker
KAFKA_CFG_ADVERTISED_LISTENERS: PLAINTEXT://kafka:9092
KAFKA_CFG_NODE_ID: 1
Expand All @@ -58,15 +59,14 @@ jobs:
env:
KGO_TEST_RF: 1
KGO_SEEDS: kafka:9092
KGO_TEST_UNSAFE: true
KGO_TEST_STABLE_FETCH: true

integration-test-redpanda:
if: github.repository == 'twmb/franz-go'
needs: golangci
runs-on: ubuntu-latest
name: "integration test redpanda"
container: golang:1.20.3
container: golang:1.21.3
services:
redpanda:
image: vectorized/redpanda-nightly:latest
Expand Down
8 changes: 8 additions & 0 deletions pkg/kgo/txn.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,6 +511,14 @@ const (
// This relies on Kafka internals. Some brokers (notably Redpanda) are
// more strict with enforcing transaction correctness and this option
// cannot be used and will cause errors.
//
// Deprecated: Kafka 3.6 removed support for the hacky behavior that
// this option was abusing. Thus, as of Kafka 3.6, this option does not
// work against Kafka. This option also has never worked for Redpanda
// becuse Redpanda always strictly validated that partitions were a
// part of a transaction. Later versions of Kafka and Redpanda will
// remove the need for AddPartitionsToTxn at all and thus this option
// ultimately will be unnecessary anyway.
EndBeginTxnUnsafe
)

Expand Down