Skip to content

Commit

Permalink
Twitter-oss: Prepare OSS libraries for release 18.8
Browse files Browse the repository at this point in the history
Problem

We want to release the next versions of our Twitter OSS libraries 18.8
 - util
 - scrooge
 - finagle
 - twitter-server
 - finatra

Solution

Prepare libraries for their next releases.

JIRA Issues: CSL-6773

Differential Revision: https://phabricator.twitter.biz/D199004
  • Loading branch information
Daniel Schobel authored and jenkins committed Aug 6, 2018
1 parent c27d13e commit d6a7069
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 10 deletions.
3 changes: 3 additions & 0 deletions CHANGES
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@

Unreleased
----------

18.8.0
-------
- scrooge-core: Add interface for Scala generated Enum objects. ``PHAB_ID=D197147``
- scrooge-core: Trait `c.t.scrooge.ThriftService` is now `c.t.finagle.thrift.ThriftServiceMarker`.
Scrooge generated service objects now all inherit from `c.t.finagle.thrift.ThriftService`. Also,
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Scrooge

[![Build status](https://travis-ci.org/twitter/scrooge.svg?branch=develop)](https://travis-ci.org/twitter/scrooge)
[![Build status](https://travis-ci.org/twitter/scrooge.svg?branch=master)](https://travis-ci.org/twitter/scrooge)
[![Codecov](https://codecov.io/gh/twitter/scrooge/branch/develop/graph/badge.svg)](https://codecov.io/gh/twitter/scrooge)
[![Project status](https://img.shields.io/badge/status-active-brightgreen.svg)](#status)
[![Gitter](https://badges.gitter.im/twitter/finagle.svg)](https://gitter.im/twitter/finagle?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge)
Expand Down
2 changes: 1 addition & 1 deletion build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import scoverage.ScoverageKeys
// 'git checkout develop; sbt publishLocal' to publish SNAPSHOT versions of these projects.

// All Twitter library releases are date versioned as YY.MM.patch
val releaseVersion = "18.8.0-SNAPSHOT"
val releaseVersion = "18.8.0"

val libthriftVersion = "0.10.0"

Expand Down
12 changes: 6 additions & 6 deletions demos/scrooge-maven-demo/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -33,27 +33,27 @@
<dependency>
<groupId>com.twitter</groupId>
<artifactId>util-core_2.12</artifactId>
<version>18.8.0-SNAPSHOT</version>
<version>18.8.0</version>
</dependency>
<dependency>
<groupId>com.twitter</groupId>
<artifactId>util-codec_2.12</artifactId>
<version>18.8.0-SNAPSHOT</version>
<version>18.8.0</version>
</dependency>
<dependency>
<groupId>com.twitter</groupId>
<artifactId>finagle-core_2.12</artifactId>
<version>18.8.0-SNAPSHOT</version>
<version>18.8.0</version>
</dependency>
<dependency>
<groupId>com.twitter</groupId>
<artifactId>finagle-thrift_2.12</artifactId>
<version>18.8.0-SNAPSHOT</version>
<version>18.8.0</version>
</dependency>
<dependency>
<groupId>com.twitter</groupId>
<artifactId>scrooge-core_2.12</artifactId>
<version>18.8.0-SNAPSHOT</version>
<version>18.8.0</version>
</dependency>
<dependency>
<groupId>junit</groupId>
Expand Down Expand Up @@ -132,7 +132,7 @@
<plugin>
<groupId>com.twitter</groupId>
<artifactId>scrooge-maven-plugin</artifactId>
<version>18.8.0-SNAPSHOT</version>
<version>18.8.0</version>
<configuration>
<thriftNamespaceMappings>
<thriftNamespaceMapping>
Expand Down
4 changes: 2 additions & 2 deletions scrooge-maven-plugin/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<artifactId>scrooge-maven-plugin</artifactId>
<packaging>maven-plugin</packaging>
<name>scrooge-maven-plugin</name>
<version>18.8.0-SNAPSHOT</version>
<version>18.8.0</version>
<prerequisites>
<maven>3.0.4</maven>
</prerequisites>
Expand Down Expand Up @@ -247,7 +247,7 @@
<dependency>
<groupId>com.twitter</groupId>
<artifactId>scrooge-generator_2.10</artifactId>
<version>18.8.0-SNAPSHOT</version>
<version>18.8.0</version>
</dependency>
<!-- Test Dependencies-->
<dependency>
Expand Down

0 comments on commit d6a7069

Please sign in to comment.