Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only log read error when WebSocket connection was closed unexpectedly #342

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

Dkamps18
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Problem/Feature

Currently logs on any WebSocket read error, normal closures also return a read error as you can't read from closed connections. These "normal closure" errors being logged can be confusing to some users

Description of Changes:

  • Only log read error when WebSocket connection was closed unexpectedly

Checklist

  • My code follows the Contribution Guide
  • I have self-reviewed the changes being requested
  • I have made comments on pieces of code that may be difficult to understand for other editors
  • I have updated the documentation (if applicable)

@Xemdo Xemdo merged commit 5788a46 into twitchdev:main Jan 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants