Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactoring 'event' subcommands #325

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

pixel365
Copy link
Contributor

@pixel365 pixel365 commented Jun 7, 2024

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Problem

The problem was that all the 'event' subcommands were located in one file 'events.go', which made it very difficult to read the code and add new subcommands if necessary.

Feature

I refactored and separated the 'event' subcommands, which in my opinion made the code noticeably cleaner and easier to understand and make changes in the future.
No functionality or behavior is broken.

Description of Changes:

  • Refactoring cmd/events.go

Checklist

  • My code follows the Contribution Guide
  • I have self-reviewed the changes being requested
  • I have made comments on pieces of code that may be difficult to understand for other editors
  • I have updated the documentation (if applicable)

@Xemdo Xemdo assigned Xemdo and unassigned Xemdo Jun 7, 2024
@Xemdo Xemdo self-requested a review June 7, 2024 16:39
@Xemdo Xemdo merged commit fb0262e into twitchdev:main Jun 18, 2024
4 checks passed
@pixel365 pixel365 deleted the feat/events-refactoring branch June 25, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants