Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forwarding events carried over WebSockets reconnect doesn't work #318

Merged
merged 3 commits into from
Mar 29, 2024
Merged

Conversation

Xemdo
Copy link
Contributor

@Xemdo Xemdo commented Mar 12, 2024

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Problem/Feature

See #315.

NOTE: Overall this is a bigger tech debt issue that I described in #317. This fix resolves the issue for end-users, but does not fix the underlying mistakes that led to this issue.

Description of Changes:

  • Fixed issue by removing the subscription object's awareness of the client name. It already lived in the map that held the Subscription objects, so we will rely on this from now on to avoid duplicating info.

Checklist

  • My code follows the Contribution Guide
  • I have self-reviewed the changes being requested
  • I have made comments on pieces of code that may be difficult to understand for other editors
  • I have updated the documentation (if applicable)

@Xemdo Xemdo linked an issue Mar 12, 2024 that may be closed by this pull request
@Xemdo Xemdo changed the title Fix 315 Forwarding events carried over WebSockets reconnect doesn't work Mar 12, 2024
@Xemdo Xemdo merged commit e7d0943 into main Mar 29, 2024
8 checks passed
@Xemdo Xemdo deleted the fix-315 branch March 29, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forwarding events carried over after WebSocket reconnect doesn't work
1 participant