Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds missing version parameter to verify-subscription #296

Merged
merged 2 commits into from
Dec 3, 2023
Merged

Conversation

lleadbet
Copy link
Contributor

@lleadbet lleadbet commented Dec 3, 2023

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Problem/Feature

#288 flagged that --version didn't work for twitch event verify-subscription. This was due to a missing entry into the parameters- it should correctly pass through as needed to avoid this in the future.

Description of Changes:

  • Adds version to the verify-subscription parameters as needed.

Checklist

  • My code follows the Contribution Guide
  • I have self-reviewed the changes being requested
  • I have made comments on pieces of code that may be difficult to understand for other editors
  • I have updated the documentation (if applicable)

@lleadbet lleadbet linked an issue Dec 3, 2023 that may be closed by this pull request
@lleadbet lleadbet requested a review from Xemdo December 3, 2023 21:03
@Xemdo Xemdo merged commit 11a468d into main Dec 3, 2023
8 checks passed
@Xemdo Xemdo deleted the fix/288 branch December 3, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Using verify-subscription channel.follow requires version param
2 participants