Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#571 Use pre-commit dog food and update release process for pre-commit autoupdate. #572

Merged
merged 16 commits into from
May 21, 2024
Merged

#571 Use pre-commit dog food and update release process for pre-commit autoupdate. #572

merged 16 commits into from
May 21, 2024

Conversation

adiroiban
Copy link
Member

@adiroiban adiroiban commented Dec 20, 2023 •
edited
Loading

Description

Fixes: #571

Try to reproduce the reported error.

Besides using pre-commit as part of our CI

this updates the release process to make it work with pre-commit auto-update

@adiroiban adiroiban requested a review from a team as a code owner December 20, 2023 13:03
@adiroiban adiroiban mentioned this pull request Dec 20, 2023
Closed
hynek
hynek reviewed Dec 20, 2023
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@hynek
Copy link
Member

hynek commented Dec 20, 2023

I don't think #571 is on our side tbh, but dogfooding is good regardless.

@adiroiban adiroiban changed the title #571 Use pre-commit dog food. #571 (help wanted) Use pre-commit dog food. Apr 28, 2024
@adiroiban adiroiban changed the title #571 (help wanted) Use pre-commit dog food. #571Use pre-commit dog food. Apr 28, 2024
@adiroiban
Copy link
Member Author

I don't have time to look into this.

If anyone cares about pre-commit, feel free to send a fix.

This PR demonstrates the issue and I hope that it can be use to test the fix :)

@sadikkuzu sadikkuzu mentioned this pull request Apr 28, 2024
Closed
7 tasks
@adiroiban adiroiban force-pushed the 571-pre-commit-hooks branch from 1589dc8 to e89304f Compare April 28, 2024 18:03
@adiroiban adiroiban force-pushed the 571-pre-commit-hooks branch from f4dfb08 to e9fd4eb Compare May 21, 2024 07:17
@adiroiban adiroiban mentioned this pull request May 21, 2024
Closed
7 tasks
@adiroiban adiroiban changed the title #571Use pre-commit dog food. #571 Use pre-commit dog food. May 21, 2024
@adiroiban adiroiban requested a review from a team May 21, 2024 07:20
@adiroiban adiroiban changed the title #571 Use pre-commit dog food. #571 Use pre-commit dog food and update release process for pre-commit autoupdate. May 21, 2024
@adiroiban
Copy link
Member Author

This is ready for review.

SmileyChris
SmileyChris approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@SmileyChris SmileyChris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pre-commit.rst docs fix is especially important, since I think the previous docs were actually broken with the rev they were on...
LGTM

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@adiroiban adiroiban enabled auto-merge (squash) May 21, 2024 12:28
@adiroiban
Copy link
Member Author

adiroiban commented May 21, 2024 •
edited
Loading

Thanks for the review and feedback. I have triggered auto-merge on this PR.

I have reconfigured the repo to allow merge commits

image

Previously, only squash merges were allowed

@adiroiban adiroiban merged commit 2bde077 into trunk May 21, 2024
16 checks passed
@adiroiban adiroiban deleted the 571-pre-commit-hooks branch May 21, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hynek hynek hynek left review comments

@SmileyChris SmileyChris SmileyChris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pre-commit autoupdate seems to fail
4 participants
@adiroiban @hynek @SmileyChris @sadikkuzu