Run check-manifest and other linters via GitHub Actions.

[adiroiban]

Description

This is take2 for #292

Enabled check manifest and pre-comit as part of GitHub Actions CI

We have pre-commit hook so I am not sure if this is needed.

I tried to simplify the job and removed the job matrix.

Fixes #292

Checklist

• [NA] Make sure changes are covered by existing or new tests.
• [NA] For at least one Python version, make sure local test run is green.
• Create a file in src/towncrier/newsfragments/. Describe your
  change and include important information. Your change will be included in the public release notes.
• Make sure all GitHub Actions checks are green (they are automatically checking all of the above).

[altendky]

Not my personal CI style (#292 (comment)) but it'll work. Here's a few thoughts.

[altendky]

Why is this going away?

[adiroiban]

my bad. I thought that we don't need it and that it was already moved to GitHub CI only.

I will revert...

My hope was that we can use standard tools without the need of extra tools.

[altendky]

I wasn't sure where you were going so maybe it isn't needed now? It was an honest question.

[adiroiban]

This is still need.
The towncrier is built once.
Then the wheel is uploaded as an artifact.
Then the tests will download the artifact and run the tests agains it.

---

I am not convinced that we need all this dance... but I think is better to refactor this in another PR.

[altendky]

I'm still in the boat of using the program's default config file. Even when using the 'single config file for everything' option you still end up with multiple single config files.

[adiroiban]

The plan it to move more things from setup.py into setup.cfg ... I am using it in #398

[altendky]

Any project using black will still have to have a pyproject.toml for any config there, afaik. Anyways, not a bug, just a passing opinion.

[altendky]

Use the relevant names for the step name. Why parallel for single environments? How about if: always() so you get all results in a single run rather than having to iterate through multiple failures via multiple commits and ci runs.

[altendky]

These days I tend to keep my checks one version behind (3.9 not 3.10). They are there to check the code, not see if the tools work with the latest Python. But definitely not a big deal, just sharing a thought.

[adiroiban]

I will revert. thanks. no big preference.
Just trying to reduce the number of redirections :)

[codecov]

Codecov Report

Merging #396 (1bb6221) into trunk (07baa2b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            trunk     #396   +/-   ##
=======================================
  Coverage   97.85%   97.85%           
=======================================
  Files          22       22           
  Lines        1400     1400           
  Branches      130      130           
=======================================
  Hits         1370     1370           
  Misses         15       15           
  Partials       15       15           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[adiroiban]

Thanks for your help.

In the end, this is not much better.

it just helped me understand the (what I consider convoluted) way in which towncrier CI works... with all the build phase and tox_build.sh external script.

I would still like to merge it as I hope that in the future we can update the CI and remove the build and tox_build.sh script.

[adiroiban]

I have enbabled auto-merge for this.

There are some README updates...and no other big changes.