Integrate new video track switch off interface #208
Conversation
| "kind" : "remoteSourceControl", | ||
| "location" : "https://github.com/twilio/twilio-video-ios", | ||
| "location" : "git@github.com:twilio/twilio-video-ios-internal-package.git", |
There was a problem hiding this comment.
Must use public package before merging to main branch.
| @@ -117,7 +117,7 @@ private extension TwilioEnvironment { | |||
| switch self { | |||
| case .production: return "twilio-video-react.appspot.com" | |||
| case .staging: return "stage-dot-twilio-video-react.appspot.com" | |||
| case .development: return "dev-dot-twilio-video-react.appspot.com" | |||
| case .development: return "large-rooms-dev-dot-twilio-video-react.appspot.com" | |||
There was a problem hiding this comment.
To test the app, switch environment to development in settings > internal > environment.
I'm thinking about how I'm going to distribute this app for testing. I wonder if I should just hardcode environment to development for now. I may do that.
There was a problem hiding this comment.
Also this will need to be reverted before merging to main branch.
| func remoteParticipantSwitchedOffVideoTrack( | ||
| participant: RemoteParticipant, | ||
| track: RemoteVideoTrack, | ||
| reason: Track.SwitchOffReason | ||
| ) { |
There was a problem hiding this comment.
For now I only had to update the delegate function interface. We were not previously checking disabled state for the camera track which I think was a bug. We should have been checking it and updating the UI when it was disabled. But now it just works with the new and improved track switch off API.
There was a problem hiding this comment.
In a later PR we will probably look at the switch off reason to distinguish in the UI when the user turned off the camera from when the server switched the track off. We are working on new UX designs for this.
| @@ -36,12 +36,13 @@ class ConnectOptionsFactory: NSObject { | |||
| } | |||
| } | |||
|
|
|||
| builder.defaultRspVersion = 3 | |||
There was a problem hiding this comment.
Will need to be reverted before merging to the main branch.
# Conflicts: # VideoApp/VideoApp.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Just integrate the new API for video track switch off.